Repository navigation
Accept CMUX repository-owned workload profile requests - #1071
Conversation
|
Independent exact-head review: ACCEPT |
2e00858 to
1ed16be
Compare
|
Final review receipt for exact head The adapter now validates the shared Authority remains planning/observation only; no argv/backend/resource/cache/host controls are exposed. Exact-head Verify, Cultist advisory, and CodeRabbit are green. |
teamleaderleo
left a comment
teamleaderleo
left a comment
There was a problem hiding this comment.
Exact-head follow-up on 8ef278fdee71c0b0a1580c28a2979a3539eee830: Verify and Cultist are green after the failed Verify job was rerun. The original failure came from native_hot_run_deadline_contract losing an environmental CPU observation and poisoning its shared test lock; current main is green on that same test family, and the rerun passed without adapter changes. The CMUX workload-profile adapter itself is clean on this head.
teamleaderleo
left a comment
teamleaderleo
left a comment
There was a problem hiding this comment.
Independent exact-head ACCEPT verdict for 8ef278fdee71c0b0a1580c28a2979a3539eee830.
Review fence:
- closed caller-neutral CMUX request grammar;
- exact source/profile/generation/state-class execution binding;
- no caller argv/cwd/backend/machine/resource/cache-root controls;
- complete canonical
cmux-workload-result/v1validation; - recomputation of CMUX semantic/comparison identities using the same field set and canonical JSON bytes as the current CMUX runner;
- exact source/profile/parameter/state correlation before observation;
- result/cleanup consistency, including ambiguous forced-cleanup handling;
- bounded digest-only outer observation with zero execution/host-selection/resource/redispatch authority.
The current paired CMUX producer still exposes cmux.ci.guard@1 and cmux.macos.dev-check@1, result contract cmux-workload-result/v1, and matching semantic/context-key algorithms.
Exact-head hosted checks:
- Verify run 35635927962: success;
- Cultist advisory run 35635927873: success.
The earlier Verify failure was the unrelated native hot-run empty-file test race, repaired and merged separately in #1086. I found no remaining blocker in this adapter fence. GitHub cannot record an APPROVE event because the implementation agents share the PR owner's account; this COMMENT records the implementation-independent verdict.
1 participant
CMUX needs one stable operation vocabulary shared by CI, developer machines, fleet acceptance, routing experiments, and performance work. The semantic definitions now live in the paired CMUX change, manaflow-ai/cmux#13411.
This adds the Glaeda-side boundary for those repository-owned profiles without copying CMUX command lines or pass/fail rules.
Result
scripts/cmux_workload_request.pyaccepts a bounded semantic request containing exact CMUX commit/tree, CMUX profile ID/generation, benchmark state class, and bounded semantic parameters.It resolves only the fixed
cmux-repository-profile/v1adapter:scripts/ci/cmux_workload_profile.py;cmux-workload-result/v1.Caller correlation and reuse hints stay outside the execution binding. A profile generation change changes that binding. The request surface has no caller-provided argv, cwd, machine/backend, resource override, cache root, or redispatch authority.
After physical execution,
observeaccepts only canonical CMUX semantic-result bytes and verifies exact source, profile ID/generation, parameters, benchmark state, semantic validator presence, artifact collection, and cleanup evidence. It stores the exact CMUX result digest and projects the CMUX terminal vocabulary without re-evaluating CMUX validity.Synthetic proof
docs/experiments/cmux-workload-profile/contains a deterministic synthetic request and plan forcmux.ci.guard@1. The OIDs are synthetic so this proves the request/plan boundary without claiming a physical worker ran.The docs also map the initial acceptance roles:
cmux_linux_ci->cmux.ci.guard@1;cmux_macos_native_build->cmux.macos.dev-check@1.Physical dispatch is the next slice: exact source materialization, CMUX runner preflight, Glaeda-owned backend/cache placement, CMUX runner execution, then a Glaeda physical receipt wrapping the CMUX semantic-result digest.
Validation
Related: #148, #546, #547, #1056, #1057, #743.
Paired CMUX implementation: manaflow-ai/cmux#13411.